Skip to content

examples: fix android example cannot be generated continuously #8621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

devojony
Copy link
Contributor

@devojony devojony commented Jul 22, 2024

When generation ends completion_loop() should return a NULL, not the empty string

When generation ends `completion_loop()` should return a NULL, not the empty string
@github-actions github-actions bot added android Issues specific to Android examples labels Jul 22, 2024
@devojony devojony changed the title fix: Android example cannot be generated continuously examples: fix android example cannot be generated continuously Jul 22, 2024
@ggerganov ggerganov merged commit b7c11d3 into ggml-org:master Jul 22, 2024
1 check passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 27, 2024
…org#8621)

When generation ends `completion_loop()` should return a NULL, not the empty string
@devojony devojony deleted the fix/example-android branch November 12, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Issues specific to Android examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants