ggml: Add epsilon as a parameter for group_norm #8818
Conversation
github-actions
bot
added
testing
| return ggml_group_norm_impl(ctx, a, n_groups, false); | ||
| int n_groups, | ||
| float eps) { | ||
| return ggml_group_norm_impl(ctx, a, n_groups, eps, false); |
There was a problem hiding this comment.
(Side question) Is ggml_group_norm equivalent to ggml_norm with ggml_reshape to group rows together beforehand and split them back afterwards?
MollySophia
force-pushed
the
groupnorm_eps
branch
from
6b20811 to
3603bb8
Compare
Signed-off-by: Molly Sophia <[email protected]>
MollySophia
force-pushed
the
groupnorm_eps
branch
from
3603bb8 to
2bdcb7b
Compare
mofosyne
added
Review Complexity : Low
|
Hmm... It seems that one of the ci checks is failing |
Seems like a timeout. I've seen that test fail before for the same reason, and usually it passes when retried. The timeout for the slot erase in the server test suite is likely too short when all is run at the same time. Not sure why it only times out in the Release build and not also in the slower builds with sanitizers. (I've restarted the failing check) (EDIT: still fails. Hmm.) |
|
Yeah, that test started failing recently for some reason - definitely not related to this PR. I tried to figure out where to increase the timeout for slot erasure, but could figure out. Would be nice if fix this eventually |
Signed-off-by: Molly Sophia <[email protected]>
Hi! I'm working on adding RWKV implementation in llama.cpp. The graph needs a custom eps value for group_norm.
This PR adds epsilon as a parameter for group_norm operators.