common : bring back missing args, add env var duplication check #9375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
approved these changes
Sep 8, 2024
ggerganov
approved these changes
Sep 8, 2024
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
…-org#9375) * common : bring back missing args * move duplication check to test-arg-parser * add check for duplicated env var * correct default values
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
…-org#9375) * common : bring back missing args * move duplication check to test-arg-parser * add check for duplicated env var * correct default values
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
…-org#9375) * common : bring back missing args * move duplication check to test-arg-parser * add check for duplicated env var * correct default values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of my code in #9308 was auto-generated using a script. The script takes
gpt_params_print_usageas reference, so some args having handler code but not in usage message was dropped during the migration.This PR bring back these args:
--prio--prio-batch--prio-draft-Cbd, --cpu-mask-batch-draft(note: this arg didn't had a handler in old version)--prio-batch-draft--perplexity(note: same as--all-logits)--output-file(note: same as-o)--save-all-logits, --kl-divergence-base--chunk(note: same as--from-chunk)Some args like
-i,-if,--in-prefix, was mislabeled asLLAMA_EXAMPLE_INFILLwhile they should be inLLAMA_EXAMPLE_MAINAlso add duplication check for env var handlers