Skip to content

llama.cpp: Add a missing header for cpp23 #9508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

ykhrustalev
Copy link
Contributor

@ykhrustalev ykhrustalev commented Sep 16, 2024

The problem occurs when compiling using cpp23 due to the use of std::upper_bound.

If you are interested in adding a matrix for cpp17/23 in the CI I can do that.

Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is not needed - we don't officially support C++ standards later than C++11. We can accept minor compatibility changes such as this, but in general the code should be compiled with C++11.

@ggerganov ggerganov merged commit 503147a into ggml-org:master Sep 17, 2024
52 checks passed
@ykhrustalev ykhrustalev deleted the cpp23-alg branch September 17, 2024 10:47
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants