Skip to content

llama : rename batch to ubatch #9950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

llama : rename batch to ubatch #9950

merged 1 commit into from
Oct 22, 2024

Conversation

danbev
Copy link
Collaborator

@danbev danbev commented Oct 19, 2024

This commit renames the member field batch in llm_build_context to ubatch, and also the parameter batch in llama_build_graph, and llama_set_inputs to ubatch.

The motivation for this change is to make the code more readable (considering there are the structs llama_batch and llama_sbatch), and consistent with other parts of the code base where parameters/fields of type llama_ubatch are named ubatch.

@danbev
llama : rename batch to ubatch
761384a 
This commit renames the member field batch in llm_build_context to
ubatch, and also the parameter batch in llama_build_graph, and
llama_set_inputs to ubatch.

The motivation for this change is to make the code more readable
(considering there are the structs llama_batch and llama_sbatch), and
consistent with other parts of the code base where parameters/fields of
type llama_ubatch are named ubatch.
@ggerganov ggerganov merged commit 19d900a into ggml-org:master Oct 22, 2024
53 checks passed
danbev added a commit to danbev/llama.cpp that referenced this pull request Oct 26, 2024
@danbev
llama : rename missed batch params/vars to ubatch
c76851e 
This commit renames the `batch` parameter to `ubatch` in the
`llama_kv_cache_find_slot`, `llm_build_inp_embd`, and
`llm_build_mamba` functions.

The motivation for this is that this should have been done as part of
Commit 19d900a ("llama : rename batch
to ubatch (ggml-org#9950)") but for some reason I missed these functions in
that commit and only noticed them now (sorry).
@danbev danbev mentioned this pull request Oct 26, 2024
Merged
4 tasks
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
@danbev @dsx1986
llama : rename batch to ubatch (ggml-org#9950)
a6bdd2b 
This commit renames the member field batch in llm_build_context to
ubatch, and also the parameter batch in llama_build_graph, and
llama_set_inputs to ubatch.

The motivation for this change is to make the code more readable
(considering there are the structs llama_batch and llama_sbatch), and
consistent with other parts of the code base where parameters/fields of
type llama_ubatch are named ubatch.
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
@danbev @dsx1986
llama : rename batch to ubatch (ggml-org#9950)
523d475 
This commit renames the member field batch in llm_build_context to
ubatch, and also the parameter batch in llama_build_graph, and
llama_set_inputs to ubatch.

The motivation for this change is to make the code more readable
(considering there are the structs llama_batch and llama_sbatch), and
consistent with other parts of the code base where parameters/fields of
type llama_ubatch are named ubatch.
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
@danbev @arthw
llama : rename batch to ubatch (ggml-org#9950)
8e01f76 
This commit renames the member field batch in llm_build_context to
ubatch, and also the parameter batch in llama_build_graph, and
llama_set_inputs to ubatch.

The motivation for this change is to make the code more readable
(considering there are the structs llama_batch and llama_sbatch), and
consistent with other parts of the code base where parameters/fields of
type llama_ubatch are named ubatch.
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
@danbev @arthw
llama : rename batch to ubatch (ggml-org#9950)
798d274 
This commit renames the member field batch in llm_build_context to
ubatch, and also the parameter batch in llama_build_graph, and
llama_set_inputs to ubatch.

The motivation for this change is to make the code more readable
(considering there are the structs llama_batch and llama_sbatch), and
consistent with other parts of the code base where parameters/fields of
type llama_ubatch are named ubatch.
danbev added a commit to danbev/llama.cpp that referenced this pull request Jan 3, 2025
@danbev
llama : rename missed batch params/vars to ubatch
b4ee830 
This commit renames the `batch` parameter to `ubatch` in the
`llama_kv_cache_find_slot`, `llm_build_inp_embd`, and
`llm_build_mamba` functions.

The motivation for this is that this should have been done as part of
Commit 19d900a ("llama : rename batch
to ubatch (ggml-org#9950)") but for some reason I missed these functions in
that commit and only noticed them now (sorry).
danbev added a commit to danbev/llama.cpp that referenced this pull request Jan 5, 2025
@danbev
llama : rename missed batch params/vars to ubatch
6e9fd00 
This commit renames the `batch` parameter to `ubatch` in the
`llama_kv_cache_find_slot`, `llm_build_inp_embd`, and
`llm_build_mamba` functions.

The motivation for this is that this should have been done as part of
Commit 19d900a ("llama : rename batch
to ubatch (ggml-org#9950)") but for some reason I missed these functions in
that commit and only noticed them now (sorry).
ggerganov pushed a commit that referenced this pull request Jan 6, 2025
@danbev
llama : rename missed batch params/vars to ubatch (#10059)
6369f86 
This commit renames the `batch` parameter to `ubatch` in the
`llama_kv_cache_find_slot`, `llm_build_inp_embd`, and
`llm_build_mamba` functions.

The motivation for this is that this should have been done as part of
Commit 19d900a ("llama : rename batch
to ubatch (#9950)") but for some reason I missed these functions in
that commit and only noticed them now (sorry).
tinglou pushed a commit to tinglou/llama.cpp that referenced this pull request Feb 13, 2025
@danbev @tinglou
llama : rename missed batch params/vars to ubatch (ggml-org#10059)
ab0a4d5 
This commit renames the `batch` parameter to `ubatch` in the
`llama_kv_cache_find_slot`, `llm_build_inp_embd`, and
`llm_build_mamba` functions.

The motivation for this is that this should have been done as part of
Commit 19d900a ("llama : rename batch
to ubatch (ggml-org#9950)") but for some reason I missed these functions in
that commit and only noticed them now (sorry).
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Feb 26, 2025
@danbev @NeoZhangJianyu
llama : rename missed batch params/vars to ubatch (ggml-org#10059)
6bf6a0a 
This commit renames the `batch` parameter to `ubatch` in the
`llama_kv_cache_find_slot`, `llm_build_inp_embd`, and
`llm_build_mamba` functions.

The motivation for this is that this should have been done as part of
Commit 19d900a ("llama : rename batch
to ubatch (ggml-org#9950)") but for some reason I missed these functions in
that commit and only noticed them now (sorry).
mglambda pushed a commit to mglambda/llama.cpp that referenced this pull request Mar 8, 2025
@danbev @mglambda
llama : rename missed batch params/vars to ubatch (ggml-org#10059)
337e9d2 
This commit renames the `batch` parameter to `ubatch` in the
`llama_kv_cache_find_slot`, `llm_build_inp_embd`, and
`llm_build_mamba` functions.

The motivation for this is that this should have been done as part of
Commit 19d900a ("llama : rename batch
to ubatch (ggml-org#9950)") but for some reason I missed these functions in
that commit and only noticed them now (sorry).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danbev @ggerganov