[SYCL] Fix build on Windows when ccache enabled (#9954) #9976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MakeDecisionWorth
commented
Oct 21, 2024
MakeDecisionWorth
commented
- I have read the contributing guidelines
- Self-reported review complexity:
- Low
- Medium
- High
|
@shou692199 |
About 5 sec on my 16C32T computer. |
ggerganov
approved these changes
Nov 9, 2024
Rbiessy
requested changes
Jan 2, 2025
There was a problem hiding this comment.
I'm not sure about this change. This seems to reduce the cache hit on Unix. Just compiling llama-bench on the main branch I get:
$ ccache -s
Cacheable calls: 192 / 288 (66.67%)
Hits: 144 / 192 (75.00%)
Direct: 144 / 144 (100.0%)
Preprocessed: 0 / 144 ( 0.00%)
Misses: 48 / 192 (25.00%)
Uncacheable calls: 96 / 288 (33.33%)
Local storage:
Cache size (GB): 0.0 / 30.0 ( 0.01%)
Hits: 144 / 192 (75.00%)
Misses: 48 / 192 (25.00%)
but with this patch this falls to 50%:
$ ccache -s
Cacheable calls: 96 / 144 (66.67%)
Hits: 48 / 96 (50.00%)
Direct: 48 / 48 (100.0%)
Preprocessed: 0 / 48 ( 0.00%)
Misses: 48 / 96 (50.00%)
Uncacheable calls: 48 / 144 (33.33%)
Local storage:
Cache size (GB): 0.0 / 30.0 ( 0.01%)
Hits: 48 / 96 (50.00%)
Misses: 48 / 96 (50.00%)
It is curious that this compiler_type is not needed on Unix. Maybe it is safer to only set it for Windows?
github-actions
bot
added
the
ggml
Rbiessy
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Thanks, I'm not sure what is the impact of setting icl as the compiler type but it should be fine. I'm happy if @NeoZhangJianyu also is.
|
I fixed some conflict, I'm planning to merge it tomorrow. |
NeoZhangJianyu
approved these changes
Mar 21, 2025
Ivy233
pushed a commit
to Ivy233/llama.cpp
that referenced
this pull request
Mar 23, 2025
…-org#9976) * [SYCL] Fix build on Windows when ccache enabled (ggml-org#9954) * take effect only on windows and force it to icl --------- Co-authored-by: Romain Biessy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.