This repository was archived by the owner on Jun 1, 2025. It is now read-only.
feat(autocomplete): Editor & Filter autocomplete feature #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiscoding
commented
Jan 10, 2019
| FilterArguments, | ||
| FilterCallback, | ||
| GridOption, | ||
| MultipleSelectOption, |
There was a problem hiding this comment.
the MultipleSelectOption is not required here
| this.searchTerms = args.searchTerms || []; | ||
|
|
||
| if (!this.grid || !this.columnDef || !this.columnFilter || (!this.columnFilter.collection && !this.columnFilter.collectionAsync && !this.columnFilter.filterOptions)) { | ||
| throw new Error(`[Angular-SlickGrid] You need to pass a "collection" (or "collectionAsync") for the MultipleSelect Filter to work correctly. Also each option should include a value/label pair (or value/labelKey when using Locale). For example:: { filter: model: Filters.multipleSelect, collection: [{ value: true, label: 'True' }, { value: false, label: 'False'}] }`); |
There was a problem hiding this comment.
the error message shouldn't include anything about MultipleSelect
| this.labelName = this.customStructure && this.customStructure.label || 'label'; | ||
| this.valueName = this.customStructure && this.customStructure.value || 'value'; | ||
|
|
||
| // always render the Select (dropdown) DOM element, even if user passed a "collectionAsync", |
There was a problem hiding this comment.
remove any reference to select dropdown
| setValues(values: SearchTerm | SearchTerm[]) { | ||
| if (values) { | ||
| values = Array.isArray(values) ? values : [values]; | ||
| this.$filterElm.multipleSelect('setSelects', values); |
There was a problem hiding this comment.
replace the setValues() with same code as the inputFilter
| collection = getDescendantProperty(collection, this.collectionOptions.collectionInObjectProperty); | ||
| } | ||
| if (!Array.isArray(collection)) { | ||
| throw new Error('Something went wrong while trying to pull the collection from the "collectionAsync" call in the Select Filter, the collection is not a valid array.'); |
There was a problem hiding this comment.
again remove reference to Select Filter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of things TODO
placeholderto tell user what to doanimated GIF of the Feature
