This repository was archived by the owner on Jun 1, 2025. It is now read-only.
fix: registered external resouces should keep singleton ref #1320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- external resources can be provided through the grid options, but these options are sometime deep copied and that might have the side effect of losing the singleton ref of the instantiate services/resources, instead we can simply keep these singleton refs before any grid options merge can happen and that is in the constructor before the grid initializes and before the grid options are merged and sometime deep copied with global options
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1320 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 896 908 +12
Branches 302 304 +2
=========================================
+ Hits 896 908 +12 ☔ View full report in Codecov by Sentry. |
ghiscoding
added a commit
that referenced
this pull request
Dec 15, 2023
- fixes issue #1329 - external resources can also be loaded globally in the forRoot and that regressed in previous PR #1320
ghiscoding
added a commit
that referenced
this pull request
Dec 16, 2023
- partially rolls back PR #1320 defining a global external resource for ExcelExport no longer worked.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs