This repository was archived by the owner on Jun 1, 2025. It is now read-only.
added option for user to select the length of autocomplete #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
- Coverage 33.26% 33.25% -<.01%
==========================================
Files 149 149
Lines 6294 6295 +1
Branches 1909 1910 +1
==========================================
Hits 2093 2093
- Misses 4193 4194 +1
Partials 8 8
Continue to review full report at Codecov.
|
ghiscoding
reviewed
May 13, 2019
| @@ -160,8 +160,9 @@ export class AutoCompleteEditor implements Editor { | |||
|
|
|||
| serializeValue() { | |||
| // if user provided a custom structure, we will serialize the value returned from the object with custom structure | |||
| const minLength = this.editorOptions.minLength || this.editorOptions.minLength === 0 ? this.editorOptions.minLength : 3; | |||
There was a problem hiding this comment.
isn't it better to do?
const minLength = typeof this.editorOptions.minLength !== 'undefined' ? this.editorOptions.minLength : 3;
|
@loonix |
|
yep, tested before I send it through |
|
|
|
I see you added Uncyclo as well, thanks for that! |
|
no problem, happy to help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Just noticed that I missed something on this feature. It is a small change but it detects if the user has used the
minLengthand applies it to the field. For example if you want the user to be able to clear the input or be able to add a text with less than 3 characters.