Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

feat(formatter): add grid formatterOptions to some Formatters & all Grouping Formatters #187

Merged
merged 2 commits into from
May 16, 2019

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented May 15, 2019

  • user can now set minDecimal, maxDecimal or displayNegativeNumberWithParentheses directly in the grid options instead of just from params
  • when user set these options through "params", they have precedence over the ones set in the grid options
  • update all tests as well

- user can now set minDecimal, maxDecimal or displayNegativeNumberWithParentheses directly in the grid options instead of just from params
- when user set these options through "params", they have precedence over the ones set in the grid options
- update all tests as well
@codecov-io
Copy link

codecov-io commented May 15, 2019

Codecov Report

Merging #187 into master will increase coverage by 0.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   37.42%   37.74%   +0.32%     
==========================================
  Files         149      150       +1     
  Lines        6426     6459      +33     
  Branches     1979     2017      +38     
==========================================
+ Hits         2404     2437      +33     
+ Misses       4013     4012       -1     
- Partials        9       10       +1
Impacted Files Coverage Δ
...lickgrid/grouping-formatters/avgTotalsFormatter.ts 100% <100%> (ø) ⬆️
...slickgrid/formatters/dollarColoredBoldFormatter.ts 100% <100%> (ø) ⬆️
...-formatters/sumTotalsDollarColoredBoldFormatter.ts 100% <100%> (ø) ⬆️
...pp/modules/angular-slickgrid/services/utilities.ts 39.72% <100%> (ø) ⬆️
...r-slickgrid/formatters/percentCompleteFormatter.ts 100% <100%> (ø) ⬆️
...grid/grouping-formatters/sumTotalsBoldFormatter.ts 100% <100%> (ø) ⬆️
...id/grouping-formatters/avgTotalsDollarFormatter.ts 100% <100%> (ø) ⬆️
...s/angular-slickgrid/formatters/percentFormatter.ts 100% <100%> (ø) ⬆️
...d/grouping-formatters/sumTotalsColoredFormatter.ts 100% <100%> (ø) ⬆️
...lickgrid/grouping-formatters/maxTotalsFormatter.ts 100% <100%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5e0c5...a2d8152. Read the comment docs.

- user can now set minDecimal, maxDecimal or displayNegativeNumberWithParentheses directly in the grid options instead of just from params
- when user set these options through "params", they have precedence over the ones set in the grid options
- move all tests to separate folder & update all necessary tests
@ghiscoding ghiscoding changed the title feat(formatter): add grid formatterOptions to all Grouping Formatters feat(formatter): add grid formatterOptions to some Formatters & all Grouping Formatters May 15, 2019
@ghiscoding ghiscoding merged commit dafc529 into master May 16, 2019
@ghiscoding ghiscoding deleted the feat/grid-formatter-options branch May 17, 2019 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants