Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

feat(formatters): consolidate all Date Formatters into 1 method call DRY #193

Merged
merged 1 commit into from
May 17, 2019

Conversation

ghiscoding
Copy link
Owner

  • all Date Formatters are built the same way, we just tell them the FieldType and the Formatter structure is the same, we can consolidate all of them into 1 method call and reduce a lot the lib footprint size while still being able to add more Date Formatters in the future

- all Date Formatters are built the same way, we just tell them the FieldType and the Formatter structure is the same, we can consolidate all of them into 1 method call and reduce a lot the lib footprint size while still being able to add more Date Formatters in the future
@codecov-io
Copy link

Codecov Report

Merging #193 into master will decrease coverage by 0.91%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #193     +/-   ##
=========================================
- Coverage   39.93%   39.02%   -0.9%     
=========================================
  Files         158      146     -12     
  Lines        6608     6510     -98     
  Branches     1960     1949     -11     
=========================================
- Hits         2638     2540     -98     
  Misses       3961     3961             
  Partials        9        9
Impacted Files Coverage Δ
...lickgrid/grouping-formatters/avgTotalsFormatter.ts 100% <100%> (ø) ⬆️
...slickgrid/formatters/dollarColoredBoldFormatter.ts 100% <100%> (ø) ⬆️
...id/grouping-formatters/avgTotalsDollarFormatter.ts 100% <100%> (ø) ⬆️
...lickgrid/grouping-formatters/sumTotalsFormatter.ts 100% <100%> (ø) ⬆️
...grid/grouping-formatters/sumTotalsBoldFormatter.ts 100% <100%> (ø) ⬆️
...ping-formatters/sumTotalsDollarColoredFormatter.ts 100% <100%> (ø) ⬆️
...s/angular-slickgrid/formatters/percentFormatter.ts 100% <100%> (ø) ⬆️
...-formatters/sumTotalsDollarColoredBoldFormatter.ts 100% <100%> (ø) ⬆️
...lickgrid/grouping-formatters/maxTotalsFormatter.ts 100% <100%> (ø) ⬆️
...s/angular-slickgrid/formatters/decimalFormatter.ts 100% <100%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82bd503...56bef72. Read the comment docs.

@ghiscoding ghiscoding merged commit ac3bac5 into master May 17, 2019
@ghiscoding ghiscoding deleted the feat/simplify-all-date-formatters branch May 22, 2019 03:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants