Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

fix(editor): dynamically adding editor column throws error, fixes #195 #212

Merged
merged 1 commit into from
May 29, 2019

Conversation

ghiscoding
Copy link
Owner

  • Column with Editors are special because we need to swap them internally in the library to a property named "internalColumnEditor", we do this because SlickGrid has "editor" reserved to a factory but that is completely different than the implementation in Angular-Slickgrid, so if user add a column dynamically, it should also be analyzed as well at that time.

- Column with Editors are special because we need to swap them internally in the library to a property named "internalColumnEditor", we do this because SlickGrid has "editor" reserved to a factory but that is completely different than the implementation in Angular-Slickgrid, so if user add a column dynamically, it should also be analyzed as well at that time.
@codecov-io
Copy link

Codecov Report

Merging #212 into master will decrease coverage by 1.69%.
The diff coverage is 42.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
- Coverage   43.25%   41.56%   -1.68%     
==========================================
  Files         146      146              
  Lines        6857     6841      -16     
  Branches     2169     2263      +94     
==========================================
- Hits         2965     2843     -122     
- Misses       3891     3995     +104     
- Partials        1        3       +2
Impacted Files Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 60.46% <42.86%> (+0.06%) ⬆️
...-slickgrid/extensions/checkboxSelectorExtension.ts 28.58% <0%> (-71.42%) ⬇️
...ular-slickgrid/extensions/headerButtonExtension.ts 40% <0%> (-60%) ⬇️
...kgrid/extensions/groupItemMetaProviderExtension.ts 50% <0%> (-50%) ⬇️
...gular-slickgrid/extensions/autoTooltipExtension.ts 52.95% <0%> (-47.05%) ⬇️
...rid/extensions/cellExternalCopyManagerExtension.ts 16.48% <0%> (-37.55%) ⬇️
...dules/angular-slickgrid/services/shared.service.ts 78.58% <0%> (-21.42%) ⬇️
...s/angular-slickgrid/extensions/extensionUtility.ts 61.91% <0%> (-14.28%) ⬇️
...ular-slickgrid/extensions/rowSelectionExtension.ts 94.12% <0%> (-5.88%) ⬇️
...dules/angular-slickgrid/services/filter.service.ts 17.38% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b7e4f1...e1ab9be. Read the comment docs.

@ghiscoding ghiscoding merged commit 444c790 into master May 29, 2019
@ghiscoding ghiscoding deleted the bugfix/dynamic-editor-column branch May 30, 2019 01:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants