This repository was archived by the owner on Jun 1, 2025. It is now read-only.
feat(sorting): add "Clear Sort" in each Column Header Menu #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiscoding
commented
Jan 9, 2019
| if (grid && dataView) { | ||
| if (forceReSort) { | ||
| this._dataView.reSort(); |
There was a problem hiding this comment.
this should be dataView instead of this._dataView
| @@ -2,6 +2,7 @@ export class Constants { | |||
| static TEXT_CANCEL = 'Cancel'; | |||
| static TEXT_CLEAR_ALL_FILTERS = 'Clear All Filters'; | |||
| static TEXT_CLEAR_ALL_SORTING = 'Clear All Sorting'; | |||
| static TEXT_CLEAR_SORT = 'Clear Sort'; | |||
There was a problem hiding this comment.
change to TEXT_REMOVE_SORT and update text
src/assets/i18n/en.json
Outdated
| @@ -3,6 +3,7 @@ | |||
| "CANCEL": "Cancel", | |||
| "CLEAR_ALL_FILTERS": "Clear All Filters", | |||
| "CLEAR_ALL_SORTING": "Clear All Sorting", | |||
| "CLEAR_SORT": "Clear Sort", | |||
There was a problem hiding this comment.
change to REMOVE_SORT and update text
ghiscoding
commented
Jan 9, 2019
| /** Sort the current column */ | ||
| private sortColumn(e: Event, args: HeaderMenuOnCommandArgs, isSortingAsc = true) { | ||
| // get previously sorted columns | ||
| const cols: ColumnSort[] = this.sortService.getPreviousColumnSorts(args.column.id + ''); |
There was a problem hiding this comment.
rename cols to sortedColsWithoutCurrent
ghiscoding
commented
Jan 9, 2019
|
|
||
| /** Clear the Sort on the current column (if it's actually sorted) */ | ||
| private clearColumnSort(e: Event, args: HeaderMenuOnCommandArgs) { | ||
| // get previously sorted columns |
There was a problem hiding this comment.
add if condition
if (args && args.column) {
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.