Set timestamp from dynamic table entity if required

[fabiomaistro]

Now if the system detects that a Timestamp property has been added to the POCO object, it automatically maps it to the Timestamp property available within the DynamicTableEntity.

[giometrix]

In your two unit tests, i notice in both cases your input is an Employee but your output is an EmployeeWithTimestamp (or EmployeeWithTimestampAsString). While a valid use case , in most situations I think programmers will use the same POCO class for both input and output.

If in these two examples we change the input object to EmployeeWithTimestamp (or WithTimestampAsString), the tests fail.

I think the fix for this is to change line 158 of EntityConvert to:
if (entity.Properties.ContainsKey(propertyInfo.Name) && propertyInfo.Name != nameof(DynamicTableEntity.Timestamp)) , but you may find a better solution.

I look forward to hearing back from you, and thank you for your contribution!

[fabiomaistro]

Hi Giovanni, thanks for your comment, I fixed the code as you suggested and also changed the unit tests accordingly.

Actually, in my case, the use case is quite different: to keep abstraction (and avoid inheriting from ITableEntity) I pass my TObject type to a generic function that is querying the table storage through a DynamicTableEntity, then I use this library to map the DynamicTableEntity to return a List<TObject>. And that's why I was testing the change in that way.
Probably you could think about adding some tests considering the scenario where the FromTableEntity is called against a new DynamicTableEntity created from scratch (and not through your ToTableEntity method).

Also, you might consider implementing the same feature I did for timestamp also for the ETag.

[giometrix]

Looks great, and I will take your advice for both suggestions (starting with ETag).

As an aside, you might want to check out (and contribute to maybe to 🤞) https://github.com/giometrix/TableStorage.Abstractions.POCO , which sounds like it might be a superset of your query function plus TableEntityConverters.

Either way, thanks!