install.iss: add Microsoft Edit as an editor option #617
Conversation
Add the newly re-written and open-source 'Edit' terminal-based text editor, inspired by the old MS-DOS Editor. Note that at this time the edit.exe program is only available as a simple zip download, or via the WinGet package manager for Windows. Since we can only rely on a stable path for the WinGet package manager we should look there (per-user). Signed-off-by: Matthew John Cheetham <[email protected]>
| @@ -1884,6 +1886,11 @@ begin | |||
| Result:=ExtractFilePath(ExtractCommandPath(Command)) + Suffix; | |||
| end; | |||
|
|
|||
| function GetMicrosoftEditPath:String; | |||
| begin | |||
| Result:=ExpandConstant('{localappdata}\Microsoft\WinGet\Packages\Microsoft.Edit_Microsoft.Winget.Source_8wekyb3d8bbwe\edit-1.0.0-x86_64-windows\edit.exe'); | |||
There was a problem hiding this comment.
Need to support ARM64, and also not hardcode the package version here.
There might soon be a MINGW-package we could theoretically use |
I wanted to check one extra thing and think about package name more. |
|
Also, it sort of conflicts with |
there shouldn't be conflict in case of MINGW environments. ${MINGW_PREFIX}/bin/edit.exe will be preferred anyway |
|
I meant the name is ambiguous. |
Add the newly re-written and open-source 'Edit' terminal-based text editor, inspired by the old MS-DOS Editor.
Note that at this time the edit.exe program is only available as a simple zip download, or via the WinGet package manager for Windows. Since we can only rely on a stable path for the WinGet package manager we should look there (per-user).