Skip to content

release-git: rank ARM64 higher than 32-bit #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

dscho
Copy link
Member

@dscho dscho commented Jan 9, 2025

The SHA-256 checksums of the Git for Windows release artifacts are listed at the bottom of Git for Windows' announcement emails.

Certain of those artifacts are deemed more important than others and are hence listed first. For example, x86_64 is nowadays considered much more important than i686 (which is deprecated, after all). To present the artifacts in such an order, the artifactName2Rank() function hard-codes CPU architecture rankings.

When ARM64 artifacts were included, this ranking was not adjusted, and as a consequence ARM64 ranked way on the bottom. However, ARM64 is the future (or will be, once GitHub comes through with the promise of hosted runners) because of battery life, performance potentials, etc, and it should therefore outrank i686.

Let's make it so!

The SHA-256 checksums of the Git for Windows release artifacts are
listed at the bottom of Git for Windows' announcement emails.

Certain of those artifacts are deemed more important than others and
are hence listed first. For example, x86_64 is nowadays considered much
more important than i686 (which is deprecated, after all). To present
the artifacts in such an order, the `artifactName2Rank()` function
hard-codes CPU architecture rankings.

When ARM64 artifacts were included, this ranking was not adjusted,
and as a consequence ARM64 ranked way on the bottom. However, ARM64
is the future (or will be, once GitHub comes through with the promise
of hosted runners) because of battery life, performance potentials,
etc, and it should therefore outrank i686.

Let's make it so!

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho requested a review from mjcheetham January 9, 2025 13:34
@dscho dscho self-assigned this Jan 9, 2025
Copy link
Member

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it so.

@dscho dscho merged commit c47fca1 into git-for-windows:main Jan 9, 2025
@dscho dscho deleted the rank-arm64-higher-than-i686 branch January 9, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants