Skip to content

Prepare for building arm64 versions of the wintoast and git-credential-manager packages #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

dscho
Copy link
Member

@dscho dscho commented Jan 9, 2023

As discussed here.

dscho added 2 commits January 9, 2023 22:00
The wintoast package contains artifacts built using Visual Studio, i.e.
we can use an x86_64 host to build an arm64 package.

The Git Credential Manager package contains artifacts that are
downloaded from that project (i.e. they are not actually built by Git
for Windows), so we can use an x86_64 host to build an arm64 package.

Therefore, let's special-case these two packages.

Signed-off-by: Johannes Schindelin <[email protected]>
These two packages do not yet exist in their arm64 version, let's
support building them without rebuilding the i686/x86_64 versions.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho
Copy link
Member Author

dscho commented Jan 9, 2023

First attempt to build and deploy wintoast.

@dscho
Copy link
Member Author

dscho commented Jan 9, 2023

First attempt to build and deploy wintoast.

That was successful. Let's try this with Git Credential Manager.

@dscho
Copy link
Member Author

dscho commented Jan 9, 2023

That one was also successful.

@dscho dscho requested a review from dennisameling January 9, 2023 21:29
@dscho dscho marked this pull request as ready for review January 9, 2023 21:29
@dscho dscho merged commit 16bcf1e into main Jan 10, 2023
@dscho dscho deleted the wintoast-and-gcm-and-arm64 branch January 10, 2023 07:07
@dscho dscho self-assigned this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants