build-and-deploy: fix the run-name for MSYS builds #3

dscho · 2022-12-19T11:30:43Z

Seems that the ${{ ... }} construct is not recursive: embedding it within itself won't have the inner one expanded. In other words, triggering an i686 build of the mintty package resulted in this very ugly title:

Build and deploy mintty (${{ inputs.architecture }})

Let's avoid that by using the format() function.

Seems that the `${{ ... }}` construct is not recursive: embedding it within itself won't have the inner one expanded. In other words, triggering an `i686` build of the `mintty` package resulted in this very ugly title: Build and deploy mintty (${{ inputs.architecture }}) For proof, see https://github.com/git-for-windows/git-for-windows-automation/actions/runs/3730919260 Let's avoid that by using the `format()` function described here: https://docs.github.com/en/actions/learn-github-actions/expressions#format Signed-off-by: Johannes Schindelin <[email protected]>

rimrul · 2022-12-19T14:28:00Z

Why did we have that nested structure to begin with? To prevent empty parantheses when inputs.architecture is unset? Is that an expected situation?

dscho · 2022-12-19T15:29:25Z

Why did we have that nested structure to begin with? To prevent empty parantheses when inputs.architecture is unset? Is that an expected situation?

Indeed, to prevent empty parentheses, and it is quite common for inputs.architecture to be unset: that's the case for all MINGW builds.

dscho self-assigned this Dec 19, 2022

dscho requested a review from rimrul December 19, 2022 11:37

rimrul approved these changes Dec 19, 2022

View reviewed changes

dscho merged commit 74b1df8 into main Dec 19, 2022

dscho deleted the fix-run-name-for-msys-builds branch December 19, 2022 22:44

Provide feedback