git-artifacts: allow building from an existing tag #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
force-pushed
the
git-artifacts-from-existing-tag
branch
3 times, most recently
from
511031d to
f5e65a4
Compare
So far, we have an implementation of the common flow where the `tag-git` workflow is started to create "bundle-artifacts" including a Git bundle with the newly-tagged Git version and another Git bundle with the updated release notes. However, for the just-published Git for Windows v2.39.2, we would like to build the ARM64 flavor of the artifacts, i.e. for an _existing_ tag. Let's introduce two new inputs (referring to an existing tag and an existing build-extra revision) that can be used instead of the input referring to a `tag-git` workflow run, and handle that scenario, too. Signed-off-by: Johannes Schindelin <[email protected]>
These inputs were used when the workflow still had its home inside git-for-windows/git, but as of its move to git-for-windows/git-for-windows-automation, they are no longer used: We either get the revision from which to build the Git artifacts from a `tag-git` workflow run or from the `existing-git-tag` input. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
git-artifacts-from-existing-tag
branch
from
f5e65a4 to
bc5d7a8
Compare
dennisameling
approved these changes
Feb 17, 2023
Comment on lines
-10
to
-17
| ref: | ||
| description: 'Optionally override which branch to build' | ||
| required: false | ||
| default: main | ||
| repository: | ||
| description: 'Optionally override from where to fetch the specified ref' | ||
| required: false | ||
| default: git-for-windows/git |
There was a problem hiding this comment.
Thanks for removing those! I noticed them earlier this week (copied over from the original pipeline) and was planning to remove them indeed :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we have an implementation of the common flow where the
tag-gitworkflow is started to create "bundle-artifacts" including a Git bundle with the newly-tagged Git version and another Git bundle with the updated release notes.However, for the just-published Git for Windows v2.39.2, we would like to build the ARM64 flavor of the artifacts, i.e. for an existing tag.
Let's introduce two new inputs (referring to an existing tag and an existing build-extra revision) that can be used instead of the input referring to a
tag-gitworkflow run, and handle that scenario, too.