open-pr: try harder to find a corresponding component-update ticket
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening a Pull Request, we would like to automatically close the corresponding `component-update` ticket, if there is any. Unfortunately, it is not _quite_ trivial to search for such tickets. One frustrating aspect is that some updates have the version number prefixed with `v` while others do not. And the search on GitHub is a bit strict about that: if you search for `0.10.1`, you won't find a ticket mentioning `v0.10.1` and the opposite is also true. We already started to special-case at least Git LFS, but it's a bit of a whack-a-mole to do that for all components we track in Git for Windows. Let's instead search for the version in both forms: both prefixed with `v` as well as without. This addresses git-for-windows/gfw-helper-github-app#18 Signed-off-by: Johannes Schindelin <[email protected]>
rimrul
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a Pull Request, we would like to automatically close the corresponding
component-updateticket, if there is any.Unfortunately, it is not quite trivial to search for such tickets. One frustrating aspect is that some updates have the version number prefixed with
vwhile others do not. And the search on GitHub is a bit strict about that: if you search for0.10.1, you won't find a ticket mentioningv0.10.1and the opposite is also true.We already started to special-case at least Git LFS, but it's a bit of a whack-a-mole to do that for all components we track in Git for Windows.
Let's instead search for the version in both forms: both prefixed with
vas well as without.This addresses
git-for-windows/gfw-helper-github-app#18