Skip to content

Commit c9b9270

Browse files
devzero2000gitster
authored andcommitted
t9360-mw-to-git-clone.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <[email protected]> Reviewed-by: Matthieu Moy <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent b352891 commit c9b9270

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

contrib/mw-to-git/t/t9360-mw-to-git-clone.sh

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -191,10 +191,10 @@ test_expect_success 'Git clone works with the shallow option' '
191191
test_path_is_file mw_dir_11/Main_Page.mw &&
192192
(
193193
cd mw_dir_11 &&
194-
test `git log --oneline Nyan.mw | wc -l` -eq 1 &&
195-
test `git log --oneline Foo.mw | wc -l` -eq 1 &&
196-
test `git log --oneline Bar.mw | wc -l` -eq 1 &&
197-
test `git log --oneline Main_Page.mw | wc -l ` -eq 1
194+
test $(git log --oneline Nyan.mw | wc -l) -eq 1 &&
195+
test $(git log --oneline Foo.mw | wc -l) -eq 1 &&
196+
test $(git log --oneline Bar.mw | wc -l) -eq 1 &&
197+
test $(git log --oneline Main_Page.mw | wc -l ) -eq 1
198198
) &&
199199
wiki_check_content mw_dir_11/Nyan.mw Nyan &&
200200
wiki_check_content mw_dir_11/Foo.mw Foo &&
@@ -218,9 +218,9 @@ test_expect_success 'Git clone works with the shallow option with a delete page'
218218
test_path_is_file mw_dir_12/Main_Page.mw &&
219219
(
220220
cd mw_dir_12 &&
221-
test `git log --oneline Nyan.mw | wc -l` -eq 1 &&
222-
test `git log --oneline Bar.mw | wc -l` -eq 1 &&
223-
test `git log --oneline Main_Page.mw | wc -l ` -eq 1
221+
test $(git log --oneline Nyan.mw | wc -l) -eq 1 &&
222+
test $(git log --oneline Bar.mw | wc -l) -eq 1 &&
223+
test $(git log --oneline Main_Page.mw | wc -l ) -eq 1
224224
) &&
225225
wiki_check_content mw_dir_12/Nyan.mw Nyan &&
226226
wiki_check_content mw_dir_12/Bar.mw Bar &&

0 commit comments

Comments
 (0)