Skip to content

Document how $HOME is set on Windows #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

alejandro5042
Copy link

Git documentation refers to $HOME and $XDG_CONFIG_HOME often, but does not specify how or where these values come from on Windows where neither is set by default. The new documentation reflects the behavior of setup_windows_environment() in compat/mingw.c.

Git documentation refers to $HOME and $XDG_CONFIG_HOME often, but does not specify how or where these values come from on Windows where neither is set by default. The new documentation reflects the behavior of setup_windows_environment() in compat/mingw.c.

Signed-off-by: Alejandro Barreto <[email protected]>
@dscho dscho merged commit b2956b3 into git-for-windows:master Mar 13, 2018
@dscho
Copy link
Member

dscho commented Mar 13, 2018

Thank you for your contribution!

And sorry for waiting so long to merge it; I meant to communicate more publicly that I was struggling with some issues in the automated build that backs the snapshots; Happily, these issues are sorted out and the next snapshot build will include your changes!

dscho added a commit that referenced this pull request Mar 23, 2018
Document how $HOME is set on Windows
@alejandro5042
Copy link
Author

For some reason, when rendered in the help HTML, it doesn't render correctly:

image

Would you know why?

@nalla
Copy link

nalla commented Mar 28, 2018

System
------------

should be

System
------

@alejandro5042
Copy link
Author

Thanks @nalla! I proposed PR #1597 to fix the formatting.

dscho added a commit that referenced this pull request Apr 3, 2018
Document how $HOME is set on Windows
dscho added a commit that referenced this pull request May 29, 2018
Document how $HOME is set on Windows
dscho added a commit that referenced this pull request May 29, 2018
Document how $HOME is set on Windows
PKRoma pushed a commit to PKRoma/git-for-windows that referenced this pull request Jun 22, 2018
PKRoma pushed a commit to PKRoma/git-for-windows that referenced this pull request Jun 22, 2018
PKRoma pushed a commit to PKRoma/git-for-windows that referenced this pull request Jun 22, 2018
dscho added a commit that referenced this pull request Aug 22, 2018
Document how $HOME is set on Windows
dscho added a commit to dscho/git that referenced this pull request Aug 22, 2018
dscho added a commit that referenced this pull request Aug 23, 2018
Document how $HOME is set on Windows
dscho added a commit that referenced this pull request Aug 23, 2018
Document how $HOME is set on Windows
dscho added a commit that referenced this pull request Aug 23, 2018
Document how $HOME is set on Windows
jamill pushed a commit to jamill/git that referenced this pull request Aug 28, 2018
jamill pushed a commit to jamill/git that referenced this pull request Sep 5, 2018
git-for-windows-ci pushed a commit that referenced this pull request Sep 10, 2018
Document how $HOME is set on Windows
jamill pushed a commit to jamill/git that referenced this pull request Sep 11, 2018
git-for-windows-ci pushed a commit that referenced this pull request Sep 24, 2018
Document how $HOME is set on Windows
dscho added a commit that referenced this pull request Oct 10, 2018
Document how $HOME is set on Windows
@sixcorners
Copy link

You mentioned $HOME and $XDG_CONFIG_HOME but this pull request just documents $HOME. What happened to $XDG_CONFIG_HOME?

@alejandro5042
Copy link
Author

@sixcorners You're right that this change only documented $HOME (as the title says) and that there still is a documentation gap with $XDG_CONFIG_HOME.

You can find how $XDG_CONFIG_HOME is set here:

https://github.com/git-for-windows/git/blob/master/path.c#L1422

Basically, it falls back on a derivative path of $HOME.

Perhaps you would like to contribute the new section for this variable?

@dscho
Copy link
Member

dscho commented Mar 25, 2019

XDG_CONFIG_HOME is not actually set by Git. If set, it is respected. If unset, Git will substitute $HOME/.config whenever it wants to find anything in XDG_CONFIG_HOME.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants