A couple of fixups for add-i-in-c-status-and-help #2191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the role of the "magic" `-1` and `-2` return values of the `list_and_choose()` function. Signed-off-by: Johannes Schindelin <[email protected]>
Let's not walk off the end of the array. Also, avoid an early `malloc()` in `add_prefix_entry()` (avoiding reuse of the same data structure for lookup as for adding a new item), and strengthen the condition for the bug condition. Signed-off-by: Johannes Schindelin <[email protected]>
|
WRT add-interactive.c, I think this helps greatly. Thanks! |
|
WRT prefix-map.c, I studied it as best I could on my iPad. I think I need to wait until I get back to my computer to look at it in more detail. But don’t let this block you. |
|
Thank you for your review! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before integrating the built-in
add -pinto Git for Windows'master, I had actually forgotten about @jeffhostetler's very helpful suggestions. Better late than never ;-)