Force UTF8 encoding of $::password
#2542
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, I was able to verify that this fixes the issue reported in #2215! I edited the commit a bit and force-pushed. Unfortunately, I messed up and force-pushed Also, the Git project really wants real names in the authorship and the signed-off-by line. Would you mind revealing your real name? |
|
I see a check for the platform and a very thoughtful commit message, so LGTM! If legal names are the custom, mine is Luke Bonanomi |
dscho
added a commit
that referenced
this pull request
Mar 11, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 11, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
|
Merged ;-) |
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 11, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 11, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 11, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 12, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 12, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 12, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 13, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 15, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 15, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 16, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 16, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
to dscho/git
that referenced
this pull request
Mar 17, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be git-for-windows#2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 17, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
Mar 17, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 18, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 18, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 18, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
Mar 18, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 18, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 18, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 18, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 19, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 19, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 19, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
Mar 20, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
Mar 23, 2020
This fixes the problem where Git was not receiving non-ASCII characters correctly in `git-gui--askpass`'s answer. This used to be #2542, but due to this maintainer's mistake, that PR was closed instead of updated ;-) Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is in support of #2215