winansi.c: Fix colourization on Cygwin pseudo terminals.

[cs96and]

Git only colours the output and uses pagination if isatty() returns 1. MSys and Cygwin emulate pseudo terminals via named pipes, meaning that isatty() returns 0.

Commit 3adef8d fixed this for MSys terminals, but not Cygwin.

The named pipes that Cygwin and Msys use are very similar. MSys PTY pipes are called 'msys--pty' and Cygwin uses 'cygwin--pty'. This commit modifies the existing check to allow both MSys and Cygwin PTY pipes to be identified as TTYs.

Note that Pagination is still broken on Cygwin. less.exe is spawned (as seen in Process Explorer and using GIT_TRACE=1), but the output is not being piped into it.

This partially fixes #267

[dscho]

Yes, please, as a single commit. Just use git commit --amend to fix the commit message and then force-push (git push <remote> +HEAD) to update this Pull Request. Thanks.

[cs96and]

When you say "re-wrap at 76 columns/line" are you talking about the source code or the commit message?

[dscho]

When you say "re-wrap at 76 columns/line" are you talking about the source code or the commit message?

Just the commit message. Source code should be wrapped at 80 columns/line. Thank you!

[dscho]

Thank you!

BTW is the first less.exe in your PATH Git for Windows' one, or is it Cygwin's?

[cs96and]

If I don't specify the pager, then Msys's less.exe gets spawned (In process explorer I see C:\Program Files\Git\usr\bin\less.exe getting spawned).

I tried overriding the pager using the PAGER and GIT PAGER variables to use cygwin's less.exe. In Process Explorer I now see c:\cygwin\bin\less.exe getting spawned, but it makes no difference. Git's output goes flying up the screen, as if it is not being piped into less

[dscho]

Hmm. I guess this needs serious investigation, still. Unfortunately I do not have the time right now, preparing the release...

[dscho]

(In order not to forget, and to give volunteers a chance to work on it, I reopened #267.)