Include trailing slash in prefix migration instructions #3790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #3786 Signed-off-by: Michael Osthege <[email protected]>
|
@dscho to me it looks like there was simply a typo. You're probably most qualified to judge if I did right change here. |
derrickstolee
approved these changes
Apr 13, 2022
|
Small pass-by comment, but when I read that error message I really thought that there was a bug in the code and |
|
Hmm. Does this still work for paths like |
1 task
But can one even encounter such a path on Windows? |
|
Do the instructions need to note the distinction between |
|
This allowed me to continue using Git without any warnings:
|
Merged
@michaelosthege That was the precise use case for The |
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 20, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 20, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 20, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
Apr 26, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
Apr 26, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
Apr 26, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
Apr 26, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
Apr 28, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
Apr 28, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
Apr 28, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
Apr 29, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
Apr 29, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
Apr 29, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
Apr 29, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
Apr 29, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
May 2, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
May 3, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
May 3, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
May 3, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
May 5, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
May 5, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
May 5, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
May 9, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
May 9, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
May 9, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
dscho
pushed a commit
that referenced
this pull request
May 9, 2022
…instructions After attempting to add directory on a network share to the `safe.directory` configuration with, for example: ``` git config --global --add safe.directory //servername/repos/myrepo ``` The warning about an outdated path style: ``` warning: encountered old-style '//servername/repos/myrepo' that should be '%(prefix)//servername/repos/myrepo' ``` However, the warning is missing a trailing `/` behind the prefix. This PR fixes the warning such that the resulting configuration works. Also see https://stackoverflow.com/a/71859164/4473230 Closes #3786
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After attempting to add directory on a network share to the
safe.directoryconfiguration with, for example:The warning about an outdated path style:
However, the warning is missing a trailing
/behind the prefix.This PR fixes the warning such that the resulting configuration works.
Also see https://stackoverflow.com/a/71859164/4473230
Closes #3786