Skip to content

Better mmap() emulation #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2015
Merged

Better mmap() emulation #486

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f21df00
win32mmap: set errno appropriately
dscho Oct 5, 2015
5cba588
mmap(win32): avoid copy-on-write when it is unnecessary
dscho Oct 13, 2015
100a1f1
mmap(win32): avoid expensive fstat() call
dscho Oct 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions compat/win32mmap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,37 +2,42 @@

void *git_mmap(void *start, size_t length, int prot, int flags, int fd, off_t offset)
{
HANDLE hmap;
HANDLE osfhandle, hmap;
void *temp;
off_t len;
struct stat st;
LARGE_INTEGER len;
uint64_t o = offset;
uint32_t l = o & 0xFFFFFFFF;
uint32_t h = (o >> 32) & 0xFFFFFFFF;

if (!fstat(fd, &st))
len = st.st_size;
else
osfhandle = (HANDLE)_get_osfhandle(fd);
if (!GetFileSizeEx(osfhandle, &len))
die("mmap: could not determine filesize");

if ((length + offset) > len)
length = xsize_t(len - offset);
if ((length + offset) > len.QuadPart)
length = xsize_t(len.QuadPart - offset);

if (!(flags & MAP_PRIVATE))
die("Invalid usage of mmap when built with USE_WIN32_MMAP");

hmap = CreateFileMapping((HANDLE)_get_osfhandle(fd), NULL,
PAGE_WRITECOPY, 0, 0, NULL);
hmap = CreateFileMapping(osfhandle, NULL,
prot == PROT_READ ? PAGE_READONLY : PAGE_WRITECOPY, 0, 0, NULL);

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view


if (!hmap)
if (!hmap) {
errno = EINVAL;
return MAP_FAILED;
}

temp = MapViewOfFileEx(hmap, FILE_MAP_COPY, h, l, length, start);
temp = MapViewOfFileEx(hmap, prot == PROT_READ ?
FILE_MAP_READ : FILE_MAP_COPY, h, l, length, start);

if (!CloseHandle(hmap))
warning("unable to close file mapping handle");

return temp ? temp : MAP_FAILED;
if (temp)
return temp;

errno = GetLastError() == ERROR_COMMITMENT_LIMIT ? EFBIG : EINVAL;
return MAP_FAILED;
}

int git_munmap(void *start, size_t length)
Expand Down