Fix cURL rc version exclusion #89
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Git for Windows project, we tried to filter out cURL's release candidate versions via a title-pattern. However, we also specify a prefix and that pattern was applied _after_ prefixing the title. Not what we want. Really only match the original feed's title (or the publication date as fallback if the feed item lacks a title). Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
fix-curl-rc-version-exclusion
branch
from
c61adc8 to
dcb0fea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Git for Windows project, we want to be notified of new cURL versions, but not of the
rc-versions. We did add a pattern to filter them out, but obviously this did not work because git-for-windows/git#5701 was opened anyway.The culprit is a long-standing bug: the
title-patternis applied after theprefixis prefixed (if any).Let's fix that, and add a test to document the intended behavior.