Skip to content

Fix Markdown linting #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Conversation

dscho
Copy link
Member

@dscho dscho commented Feb 18, 2021

What amounts to a late-night bug, I introduced a line into our Markdown linting configuration that is incorrect: "MD013/line-length" does not work.

The obvious solution is to remove the /line-length suffix, which makes it work.

But we can do even better: those numbers ("MD013") are totally not intuitive. The labels are, however, and it is totally allowed to use them! So let's use them.

It would have been nice to keep the indicator as to the real reason for
those warnings, "MD013" really does not tell anybody anything.

Signed-off-by: Johannes Schindelin <[email protected]>
Actually: what the previous commit lamented about not being possible...
_is_ possible! Yay!

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho
Copy link
Member Author

dscho commented Feb 18, 2021

@dennisameling could I bother you for a review?

@dscho dscho merged commit 947ebc6 into git-for-windows:main Feb 18, 2021
@dscho dscho deleted the fix-markdown-linting branch February 18, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant