Prepare our git-p4 tests for running on APFS #179
Conversation
dscho
force-pushed
the
skip-t9822-on-apfs
branch
from
dd73d9c to
52681ae
Compare
|
/submit |
|
Submitted as [email protected] |
![gitgitgadget[bot]](https://avatars.githubusercontent.com/in/12836?s=60&v=4){kind=small}
Most notably, it seems that macOS' APFS does not allow that. Signed-off-by: Johannes Schindelin <[email protected]>
Due to reasons (some XCode versions seem to include gettext, some don't?), Homebrew does not expose the libraries and headers in /usr/local/ by default anymore. Let's help find them again. Note: for some reason, this is a change of behavior caused by the upgrade to Mojave, identified in our Azure Pipeline; it seems that Homebrew used to add the /usr/local/ directories to the include and link search path before, but now it no longer does. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
skip-t9822-on-apfs
branch
from
f006524 to
25be67b
Compare
|
/submit |
|
Submitted as [email protected] |
|
This branch is now known as |
|
This patch series was integrated into pu via git@73a9270. |
|
This patch series was integrated into pu via git@054b28d. |
|
This patch series was integrated into pu via git@f7944e3. |
|
This patch series was integrated into pu via git@098f0aa. |
|
This patch series was integrated into pu via git@11071d0. |
|
This patch series was integrated into pu via git@f10377b. |
|
This patch series was integrated into pu via git@32b32c1. |
|
This patch series was integrated into next via git@de4cbb1. |
|
This patch series was integrated into pu via git@27a8f85. |
|
This patch series was integrated into pu via git@aa8c8d9. |
|
This patch series was integrated into next via git@aa8c8d9. |
|
This patch series was integrated into master via git@aa8c8d9. |
|
Closed via aa8c8d9. |
Azure Pipelines' macOS agents were recently upgraded to Mojave, and since that does not support HFS+ anymore, everything will be upgraded to APFS.
As I found the hard way, we have one test that fails on that filesystem (t9822, which is only run if Perforce's
p4dis available).The first patch adds a workaround, as I failed to find any way to finagle APFS into accepting that ISO-8859-1 encoded file name.
The second patch is a fix to make things compile on Mojave again, apparently Homebrew changed and the
/usr/local/directories need to be added to the compiler and linker flags explicitly. Maybe this is a gcc-8 only thing, as it seems to have affected only theosx-gccjob, not theosx-clangjob.Changes since v1:
Cc: Luke Diamand [email protected]