-
Notifications
You must be signed in to change notification settings - Fork 661
chore: Update CI and examples for Terraform #1619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
npalm
commented
Jan 12, 2022
- upgrade terraform versions
- replaced philips vpc module by aws-terraform-vpc module
- dropped support for terrform pre 1.x from examples
ScottGuymer
previously approved these changes
Jan 13, 2022
There is some conflict here. Lets solve it and get this merged. |
Will do asap. |
- upgrade terraform versions - replaced philips vpc module by aws-terraform-vpc module - dropped support for terrform pre 1.x from examples
- upgrade terraform versions - replaced philips vpc module by aws-terraform-vpc module - dropped support for terrform pre 1.x from examples - upgrade terraform versions - replaced philips vpc module by aws-terraform-vpc module - dropped support for terrform pre 1.x from examples replace local by var ref
645fbcd
to
fbf8eaf
Compare
ScottGuymer
previously approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from formatting it looks good.
ScottGuymer
reviewed
Jan 28, 2022
ScottGuymer
previously approved these changes
Jan 28, 2022
ScottGuymer
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.