Skip to content

chore: Update CI and examples for Terraform #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 28, 2022
Merged

Conversation

npalm
Copy link
Member

@npalm npalm commented Jan 12, 2022

  • upgrade terraform versions
  • replaced philips vpc module by aws-terraform-vpc module
  • dropped support for terrform pre 1.x from examples

@npalm npalm marked this pull request as draft January 12, 2022 22:06
@npalm npalm marked this pull request as ready for review January 12, 2022 22:20
@npalm npalm requested a review from ScottGuymer January 12, 2022 22:20
@npalm npalm changed the title chore: Update Ci and examples for Terraform chore: Update CI and examples for Terraform Jan 12, 2022
ScottGuymer
ScottGuymer previously approved these changes Jan 13, 2022
@ScottGuymer
Copy link
Contributor

There is some conflict here. Lets solve it and get this merged.

@npalm
Copy link
Member Author

npalm commented Jan 27, 2022

Will do asap.

npalm added 2 commits January 28, 2022 11:35
- upgrade terraform versions
- replaced philips vpc module by aws-terraform-vpc module
- dropped support for terrform pre 1.x from examples
- upgrade terraform versions
- replaced philips vpc module by aws-terraform-vpc module
- dropped support for terrform pre 1.x from examples

- upgrade terraform versions
- replaced philips vpc module by aws-terraform-vpc module
- dropped support for terrform pre 1.x from examples

replace local by var ref
@npalm npalm requested a review from ScottGuymer January 28, 2022 10:44
ScottGuymer
ScottGuymer previously approved these changes Jan 28, 2022
Copy link
Contributor

@ScottGuymer ScottGuymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from formatting it looks good.

@npalm npalm requested a review from ScottGuymer January 28, 2022 10:53
ScottGuymer
ScottGuymer previously approved these changes Jan 28, 2022
@npalm npalm merged commit db4fc4b into develop Jan 28, 2022
@npalm npalm deleted the npalm/terraform-versions branch January 28, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants