-
Notifications
You must be signed in to change notification settings - Fork 661
feat: Add variable to allow userdata to be passed as string to aws launch template #1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add variable to allow userdata to be passed as string to aws launch template #1963
Conversation
Note: check conflicts with #1956 |
Sounds good, I'll rebase my changes on top of that PR |
As this is a quite advanced usecase I think this needs an example to show a potential user how to do this and call out some of the things they need to consider along the way. |
I am also open to adding a |
Yes, I think an example of how to use this is warranted. With some notes in the readme to guide the user when they might want to use it and what issues there could be. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rashidnhm please can you rebase the PR. We have updated the module last week to AWS terraform provide 4.x
I think we are just missing the example now. |
Sounds good, currently working on getting that ready |
Hello, @ScottGuymer @npalm wondering if you got a chance to comb through this PR yet? |
Will put it on my list, sorry the PR got out of sight. Please can you have a look on the failing CI, some formatting is most likely the issue. |
@npalm Sorry about the late reply, I've fixed the formatting issue. Please take a look and let me know. |
@npalm Just checking in to see if you got a chance to comb through this? |
not yet, hope to check all the open PR's this week |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
@npalm I will try to update this PR soon and pull in all latest changes, will you have time to review anytime soon? |
I think in that case we should close, thanks fro reaching out |
Fix for the issue mentioned in #1960. This PR enables the passing of userdata script as a string to the module.
If both variables
userdata_string
anduserdata_template
are passed, thenuserdata_string
would take precedence.