feat: Allow to toggle access to EC2 instance tags #2592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
reviewed
Oct 31, 2022
There was a problem hiding this comment.
@MGSousa looks good, but curious in what case do you disable the metadaservice_tags? The instance start-up requires on tags. Or do you use an alternative user_data script to start your runners in such way you are not requiring the tags.
For this case, I need to disable this metadata service since this restricts "spacing" in tags (aws/aws-sdk#410), and for now, it's the only solution. |
npalm
requested changes
Nov 3, 2022
Co-authored-by: Niek Palm <[email protected]>
Updated description for the metadata_options variable Co-authored-by: Niek Palm <[email protected]>
npalm
approved these changes
Nov 8, 2022
forest-releaser bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
## [1.15.0](philips-labs/terraform-aws-github-runner@v1.14.0...v1.15.0) (2022-11-08) ### Features * Allow to toggle access to EC2 instance tags ([#2592](https://github.com/philips-labs/terraform-aws-github-runner/issues/2592)) ([55fba22](philips-labs/terraform-aws-github-runner@55fba22)) ### Bug Fixes * Use aws_partition for govcloud users in ami_id_ssm_parameter_read policy definition ([#2614](https://github.com/philips-labs/terraform-aws-github-runner/issues/2614)) ([7ac65e5](philips-labs/terraform-aws-github-runner@7ac65e5))
npalm
pushed a commit
that referenced
this pull request
Nov 17, 2022
## [1.15.0](philips-labs/terraform-aws-github-runner@v1.14.0...v1.15.0) (2022-11-08) ### Features * Allow to toggle access to EC2 instance tags ([#2592](https://github.com/philips-labs/terraform-aws-github-runner/issues/2592)) ([55fba22](philips-labs/terraform-aws-github-runner@55fba22)) ### Bug Fixes * Use aws_partition for govcloud users in ami_id_ssm_parameter_read policy definition ([#2614](https://github.com/philips-labs/terraform-aws-github-runner/issues/2614)) ([7ac65e5](philips-labs/terraform-aws-github-runner@7ac65e5))
npalm
pushed a commit
that referenced
this pull request
Dec 13, 2022
## [1.15.0](philips-labs/terraform-aws-github-runner@v1.14.0...v1.15.0) (2022-11-08) ### Features * Allow to toggle access to EC2 instance tags ([#2592](https://github.com/philips-labs/terraform-aws-github-runner/issues/2592)) ([55fba22](philips-labs/terraform-aws-github-runner@55fba22)) ### Bug Fixes * Use aws_partition for govcloud users in ami_id_ssm_parameter_read policy definition ([#2614](https://github.com/philips-labs/terraform-aws-github-runner/issues/2614)) ([7ac65e5](philips-labs/terraform-aws-github-runner@7ac65e5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added variable option for toggle (
enabled/disabled) access to EC2 instance tags through metadata service.