feat: Set up per runner type subnet specification for multi-runner #3516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbarnajc
changed the title
pbarnajc
changed the title
pbarnajc
force-pushed
the
allow-per-runner-subnet-config
branch
from
a76f77d to
7368f4b
Compare
|
Whoops, just saw https://github.com/philips-labs/terraform-aws-github-runner/pull/3467 is already doing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/philips-labs/terraform-aws-github-runner/issues/3515
This just adds the ability to specify a specific subnet_id for a specific runner type for the multi-runner module. There should still always be subnet_ids specified at the module level for the default, but if subnet_ids are specified at the runner level they should override the module level values.
This will enable users to have runners in different subnets without needing to call this module multiple times.