Skip to content

fix(syncer): add default filter with empty prefix due to changes in AWS Provi… #4475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

bdandoy
Copy link
Contributor

@bdandoy bdandoy commented Mar 11, 2025

…der 5.90.0

In 5.90.0 of the AWS provider they are now providing the warning below. This PR keeps the same functionality while getting rid of the warning.

No attribute specified when one (and only one) of [rule[0].prefix.<.filter] is required

This will be an error in a future version of the provider

@bdandoy bdandoy requested a review from a team as a code owner March 11, 2025 19:45
@npalm
Copy link
Member

npalm commented Mar 12, 2025

Thx for the PR. Please can you update the description with what you trying to fix please?

@bdandoy
Copy link
Contributor Author

bdandoy commented Mar 13, 2025

Description has been updated

@npalm npalm changed the title fix: add default filter with empty prefix due to changes in AWS Provi… fix(syncer): add default filter with empty prefix due to changes in AWS Provi… Mar 13, 2025
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdandoy thx!

@npalm npalm merged commit 1ba9dcc into github-aws-runners:main Mar 13, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants