Skip to content

.ci: Improve dockerfile to include caching #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

seemethere
Copy link
Contributor

@seemethere seemethere commented Mar 26, 2021

Improves dockerfile / .ci/build.sh script to output lambda zips in a
central location as well as adds buildkit caching to the docker build so
that you don't have to re-download the node_modules of each zip directly
each time you build with .ci/build.sh

This also makes improvements in that if there are only changes in one
directory then the cache will remain and the remaining lambdas will not
be re-built.

I guess an open question as well should be if there should be an additional github actions wofklow added to this?

Signed-off-by: Eli Uriegas [email protected]

Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seemethere thanks for you contribution! Just checked the chagen. First got all kind of erros. Seems the cause is the javascript heep space. Updated the memory allocated by docker from 2GB to 4GB and all works fine.

Please can you add a note about the required memory?

@seemethere
Copy link
Contributor Author

@seemethere thanks for you contribution! Just checked the chagen. First got all kind of erros. Seems the cause is the javascript heep space. Updated the memory allocated by docker from 2GB to 4GB and all works fine.

Please can you add a note about the required memory?

Done!

npalm
npalm previously approved these changes Mar 29, 2021
@npalm
Copy link
Member

npalm commented Mar 29, 2021

@seemethere Can you da me a small favour and rebase your branch due to yesterdays release?

seemethere and others added 2 commits March 29, 2021 10:08
Improves dockerfile / .ci/build.sh script to output lambda zips in a
central location as well as adds buildkit caching to the docker build so
that you don't have to re-download the node_modules of each zip directly
each time you build with .ci/build.sh

This also makes improvements in that if there are only changes in one
directory then the cache will remain and the remaining lambdas will not
be re-built.

Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
Copy link
Contributor Author

@seemethere Can you da me a small favour and rebase your branch due to yesterdays release?

Done!

@npalm npalm merged commit 65aab80 into github-aws-runners:develop Mar 29, 2021
@seemethere seemethere deleted the improve_ci_build_script branch March 29, 2021 21:36
npalm pushed a commit that referenced this pull request Jun 1, 2021
* .ci: Improve dockerfile to include caching

Improves dockerfile / .ci/build.sh script to output lambda zips in a
central location as well as adds buildkit caching to the docker build so
that you don't have to re-download the node_modules of each zip directly
each time you build with .ci/build.sh

This also makes improvements in that if there are only changes in one
directory then the cache will remain and the remaining lambdas will not
be re-built.

Signed-off-by: Eli Uriegas <[email protected]>

* Add comment about memory size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants