Git Add fails due to too many files being added

[thorade]

Steps to Reproduce

1. Open existing Unity project
2. Assets -> Import Package -> Import github-for-unity v0.15
3. create new repo from github web ui
4. in Unity, initialize and push (successfull)
5. got to changes, see 759 changes, select all, type commit message, commit

** Behavior:**
Typing the commit message is very slow.
Hitting the commit button seems to result in no action.

Reproduces how often:
100% reproducible in this project

Additional Information

Here is my log:

github-unity_log.txt

[shana]

@thorade Yeah, we're working on fixing performance problems in the Changes view (#23), it's not performing well when there's a lot of changes on screen 😢

[StanleyGoldman]

Hey @thorade you are hitting the performance problem that @shana is talking about, but there is also another issue that you've encountered here. We need to be smart about how we perform git add.

[StanleyGoldman]

If all files are being added we can shortcut with git add .
If a large subset of files are being added we need to batch the git add operation to not encounter this error.

[thorade]

Thanks. I'll try to work around it by manually adding the files in smaller chunks, tomorrow.

[StanleyGoldman]

Script to generate content for this bug

https://gist.github.com/StanleyGoldman/c84e31e174a91e1ff28770feaaf8da29

[thorade]

Just a note:
In my case, ~650 of the ~750 files were from one asset (SteamVR) that is available for free on the asset store.
https://www.assetstore.unity3d.com/
Unfortunately, it is not possible to just define such dependencies (and their versions) and let Unity handle it as it would be done with npm+node.js or pip+Python:
http://minhhh.github.io/posts/unity-package-management

[StanleyGoldman]

Yea, that would be nice.

Either way, that script right there generates about 800 files and folders. Enough for me to see the problem you were talking about.

I have a PR #119 that reduces the amount of time it takes to generate the three by ~%80, but it's still kinda slow with 800 items in the tree.

I'm trying to fix the add functionality now...