This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Fix authentication again #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanleyGoldman
previously requested changes
Jul 24, 2018
Fix signin/signout not available if there's no repo. Fix signout of the active connection. Fix mismatches between what's in the connections file to what we're trying to signout or load the keychain for.
- Make sure we save the token before verifying the token, and save the new username after verifying it - Minimize how many times we query the cred manager
shana
force-pushed
the
fix-authentication-again
branch
from
6eb9dfa to
43828e6
Compare
StanleyGoldman
approved these changes
Aug 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While spelunking in the code I noticed that there were a bunch of problems with the authentication:
I tried to fix these as I found them and simplify the code, especially around running octorun and setting environment variables there (the user is never used by octorun so I killed that).
I was also annoyed by the fact that zip does not create deterministic zips - i.e. the exact same content produces different zip files because zip stores the file timestamps (including access time ???), and those can be anything, so I added a packaging submodule with a typescript thing to produce deterministic zips. I haven't tested this particular step on Windows yet - it only requires node to be installed in the system and nothing else, so it should work fine?