Skip to content

Fix FP reported in #372 #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Fix FP reported in #372 #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions change_notes/2024-02-01-fix-fp-reported-for-a7-1-1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
`A7-1-1` - `DeclarationUnmodifiedObjectMissingConstSpecifier.ql`
- Fix FP reported in #372. Exclude compiler generated variables.
3 changes: 2 additions & 1 deletion cpp/autosar/src/rules/A7-1-1/DeclarationUnmodifiedObjectMissingConstSpecifier.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,6 @@ where
else cond = " is used for an object"
) and
not exists(LambdaExpression lc | lc.getACapture().getField() = v) and
not v.isFromUninstantiatedTemplate(_)
not v.isFromUninstantiatedTemplate(_) and
not v.isCompilerGenerated()
select v, "Non-constant variable " + v.getName() + cond + " and is not modified."