Add isVideo check, similar to isImage #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bestra
force-pushed
the
bestra/add-is-video
branch
from
491617c to
79895d6
Compare
dgreif
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/github/github/pull/162936 we added an
isVideofunction to a downstream file, mentioning that we should eventually put it intofile-attachment-element.https://github.com/github/github/blob/8c9b18cf24713d8be3888f31205ec43ff9f8e7a0/app/assets/modules/github/behaviors/commenting/markdown.ts#L38-L42
There's nothing depending on this change yet. I'm drafting some other changes and figured I'd take a shot at it while I was here.