-
Notifications
You must be signed in to change notification settings - Fork 5
Introduce publish
workflow
#14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.
|
Looks like it's already set! Related Slack thread |
cache: npm | ||
- run: npm ci | ||
- run: npm test | ||
- run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add an if: ${{ success() }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming the workflow will work as copied from the frontend-project, publish.yml template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this same setup is working in eslint-plugin-github
just fine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming that if there's a failure, the next run
command wouldn't run since this seems to all be one job rather than parallel jobs... 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s included implicitly; from “Status check functions”:
A default status check of
success()
is applied unless you include one of these [other status check] functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool Cool! thank you
Yay! The workflow worked: publish.yml output |
Fixes: #7
I am following the steps in TheHub: Publishing npm packages so the package is automatically published upon creation of release.