Skip to content

Introduce publish workflow #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Introduce publish workflow #14

merged 1 commit into from
Dec 21, 2022

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Dec 21, 2022

Fixes: #7

I am following the steps in TheHub: Publishing npm packages so the package is automatically published upon creation of release.

@khiga8 khiga8 marked this pull request as ready for review December 21, 2022 18:21
@khiga8 khiga8 requested a review from a team as a code owner December 21, 2022 18:21
@accessibility-bot
Copy link
Collaborator

👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.

  • 💻 On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos (with description following) demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • ⚠️ If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

@khiga8
Copy link
Contributor Author

khiga8 commented Dec 21, 2022

Hold on merge until we get web systems to add the token we need!

Looks like it's already set! Related Slack thread

cache: npm
- run: npm ci
- run: npm test
- run: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add an if: ${{ success() }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the workflow will work as copied from the frontend-project, publish.yml template.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this same setup is working in eslint-plugin-github just fine!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that if there's a failure, the next run command wouldn't run since this seems to all be one job rather than parallel jobs... 🤔

Copy link
Contributor

@smockle smockle Dec 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s included implicitly; from “Status check functions”:

A default status check of success() is applied unless you include one of these [other status check] functions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool Cool! thank you

@khiga8 khiga8 merged commit 99ae27a into main Dec 21, 2022
@khiga8 khiga8 deleted the kh-publish-workflow branch December 21, 2022 20:00
@khiga8
Copy link
Contributor Author

khiga8 commented Dec 21, 2022

Yay! The workflow worked: publish.yml output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make publish step more automated
4 participants