Skip to content

Add no-alt-text rule to accessibility.json #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Dec 21, 2022

I am understanding the accessibility.json rule to have configurations explicitly for accessibility-focused rules. (let me know if my understanding is wrong)

This rule will already be pulled in by the default: true setting in base.json, but I think we should explicitly enable it here too.

@khiga8 khiga8 requested a review from a team as a code owner December 21, 2022 21:50
@accessibility-bot
Copy link
Collaborator

👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.

  • 💻 On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos (with description following) demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • ⚠️ If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

@khiga8
Copy link
Contributor Author

khiga8 commented Dec 21, 2022

@andrialexandrou I'd appreciate if you could provide background on the setup of base.json and accessibility.json! 🙇‍♀️

@andrialexandrou
Copy link
Collaborator

@khiga8 correct, the idea is to identify which rules are specifically related to accessibility.

If we want to, in the future, configure tracking around discouraging teams disabling accessibility-related markdown rules, then we've identified which ones we care about.

@khiga8 khiga8 merged commit 1041294 into main Dec 22, 2022
@khiga8 khiga8 deleted the kh-add-no-alt-text-rule branch December 22, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants