Skip to content

Safe-settings doesn't create branch protection and org rulesets #842

Open
@Ali-Dalal

Description

@Ali-Dalal

Problem Description

I am trying to create branch protection via repo.yml as follow:

repository:
  description: updated description from safe-settings
  branches:
  # If the name of the branch value is specified as `default`, then the app will create a branch protection rule to apply against the default branch in the repo
  - name: main # default doesn't work as well
    protection:
      required_pull_request_reviews:
        required_approving_review_count: 3
        dismiss_stale_reviews: true
        require_code_owner_reviews: true
        require_last_push_approval: true
        bypass_pull_request_allowances:
          apps: []
          users: []
          teams: []
        dismissal_restrictions:
          users: []
          teams: []
      required_status_checks:
        strict: true
        contexts: []
      enforce_admins: true
      restrictions:
        apps: []
        users: []
        teams: []

What is actually happening

only description is being updated. in safe-settings pull request dry-run, I see that there are changes to be applied related to branch protection but after merging the pull-request, only description is being changed.

What is the expected behavior

branch protection rule should be created

Error output, if available

There are no errors. I can only see webhook successfully applied.


Context

Also I tried to create org rulesets by adding a sample to settings.yml but also it is not creating but other settings like topics is creating.
I tried to call GitHub api with same branch-protection-rule body and using same credentials (github-app) and the rule is created.

Are you using the hosted instance of probot/settings or running your own?

own using docker image ghcr.io/github/safe-settings:2.1.17

If running your own instance, are you using it with github.com or GitHub Enterprise?

GitHub Enterprise

Version of probot/settings

2.1.17

Version of GitHub Enterprise

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions