-
Notifications
You must be signed in to change notification settings - Fork 174
fix: Re-enable creation of the new repositories #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main-enterprise
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the repository-fetch logic to include repos defined in the config but missing from the API response.
- Introduces tracking of processed repos to avoid duplicates
- Splits processing into existing and missing repos batches
- Concatenates and filters both result sets before returning
This change still requires |
Hi @klutchell. Yes, it requires safe-settings/lib/plugins/repository.js Line 121 in 3e5d4fe
Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A fix to ensure newly configured repositories that aren’t returned by the installation API still get processed.
- Split repository handling into “existing” (via GitHub paginate) and “missing” (from configuration) batches
- Track which repos have been processed to avoid duplicates
- Concatenate results from both batches and filter out nulls
Comments suppressed due to low confidence (1)
lib/settings.js:508
- [nitpick] Rename
repoInConfigs
to something likeconfiguredRepos
orreposFromConfig
to more clearly express its purpose.
const repoInConfigs = Object.values(this.repoConfigs)
Hi all,
This PR fixes issue safe-settings/issues/780.
The code that returns the list of all repositories does not include one that does not exist.
Cheers! 👋