Remove dangling pointer to tab widget when removing an autohide widget #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom autohide side bar
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the removal of a dangling pointer to the tab widget when an auto-hide widget is removed.
- Clears the side-tab widget pointer in the dock widget via setSideTabWidget(nullptr).
- Removes and detaches the SideTab from its parent container.
Comments suppressed due to low confidence (1)
src/AutoHideDockContainer.cpp:428
- [nitpick] Consider renaming the variable 'SideTab' to follow consistent naming conventions (e.g. 'sideTab') used in the project.
auto SideTab = d->SideTab;
| @@ -425,8 +425,8 @@ void CAutoHideDockContainer::cleanupAndDelete() | |||
| const auto dockWidget = d->DockWidget; | |||
| if (dockWidget) | |||
| { | |||
|
|
|||
| auto SideTab = d->SideTab; | |||
There was a problem hiding this comment.
[nitpick] Adding a short comment to highlight that clearing the pointer prevents a dangling reference could improve code clarity and future maintenance.
Suggested change
| auto SideTab = d->SideTab; | |
| auto SideTab = d->SideTab; | |
| // Clear the pointer to prevent a dangling reference after the SideTab is removed. |
Copilot uses AI. Check for mistakes.
|
Thank your for this fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would fix #739
Tested locally. Results below
I am still unsure wether
DockWidget::isAutoHide()should query the dockArea.Also, I find it a bit weird that the pointer is assigned by
CAutoHideSideBarbut removed byAutoHideDockContainer. But looking at the call graph, every one calls theCAutoHideDockContainer::cleanupAndDeletefunction whileCAutoHideSideBar.removeAutoHideWidgetis only called when a tab moves from one sidebar to another.