Skip to content

Fix #858: Added missing TopicsApi #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 19, 2023
Merged

Fix #858: Added missing TopicsApi #1012

merged 9 commits into from
Sep 19, 2023

Conversation

NadeoWolf
Copy link
Contributor

Added the missing TopicsAPI.
Due to compatibility problems with Maven, I have only been able to test the new functions manually.

@NadeoWolf NadeoWolf mentioned this pull request Jul 31, 2023
Closed
@NadeoWolf
Removed Topic and TopicID from existing Methods to mantain backwards …
f63fef9 
…compatibility.

Added 'topic', 'topic_id' and 'imported'(Missing) to ProjectFilter instead.
jmini
jmini requested changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some unit tests should be extended (I can have a look).

Thank you very much for this contribution!

jmini
jmini reviewed Aug 15, 2023
View reviewed changes
jmini
jmini reviewed Aug 15, 2023
View reviewed changes
jmini
jmini reviewed Aug 15, 2023
View reviewed changes
jmini
jmini reviewed Aug 15, 2023
View reviewed changes
jmini
jmini reviewed Aug 15, 2023
View reviewed changes
jmini
jmini approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good now. Also the maven build is green.

I think it would be good to perform manual tests against a real GitLab instance.

jmini
jmini reviewed Aug 18, 2023
View reviewed changes
jmini
jmini reviewed Aug 18, 2023
View reviewed changes
jmini
jmini reviewed Aug 18, 2023
View reviewed changes
jmini
jmini reviewed Aug 18, 2023
View reviewed changes
jmini
jmini reviewed Aug 18, 2023
View reviewed changes
jmini
jmini reviewed Aug 18, 2023
View reviewed changes
jmini
jmini requested changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some work to do (see comments)

@NadeoWolf
Copy link
Contributor Author

Im on Holiday. Will check it after 4. September.

@jmini
Copy link
Collaborator

jmini commented Aug 21, 2023

Will check it after 4. September.

No problem.
I had some fixes locally. I pushed them to your branch.

jmini
jmini approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 👍

I would like to perform some manual tests before I merge.

Thank you for this contribution 🎉

jmini
jmini reviewed Sep 18, 2023
View reviewed changes
jmini added a commit to jmini/gitlab-experiments that referenced this pull request Sep 19, 2023
@jmini
Add TopicsScript
88d4561 
Test for gitlab4j/gitlab4j-api#1012
@jmini jmini merged commit 69c7096 into gitlab4j:main Sep 19, 2023
@trp-samer-adra
Copy link

Any idea when this is getting released? Hoping to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmini jmini jmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NadeoWolf @jmini @trp-samer-adra