Skip to content

#1010 get .gitlab-ci.yml template #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 8, 2023
Merged

#1010 get .gitlab-ci.yml template #1026

merged 4 commits into from
Sep 8, 2023

Conversation

DoubleDPro
Copy link
Contributor

Added Gitlab CI YAML templates API

Fixes #1010

@DoubleDPro
gitlab4j#1010 get .gitlab-ci.yml template
74e4cee 
Added Gitlab CI YAML templates API
jmini
jmini approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Thank you for this contribution.

I will test this manually and merge.

jmini
jmini reviewed Sep 5, 2023
View reviewed changes
src/main/java/org/gitlab4j/api/models/CiYamlTemplatesApi.java Outdated
*
* @see <a href="https://https://docs.gitlab.com/ee/api/templates/gitlab_ci_ymls.html">GitLab CI YAML API</a>
*/
public class CiYamlTemplatesApi extends AbstractApi {
Copy link
Collaborator

@jmini jmini Sep 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the class should be named CiYaml or GitLabCiYaml

to match the title of the docs GitLab CI YAML API
https://docs.gitlab.com/ee/api/templates/gitlab_ci_ymls.html

jmini
jmini reviewed Sep 8, 2023
View reviewed changes
src/main/java/org/gitlab4j/api/models/CiYamlTemplatesApi.java Outdated
@@ -0,0 +1,49 @@
package org.gitlab4j.api.models;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong package

jmini
jmini reviewed Sep 8, 2023
View reviewed changes
src/main/java/org/gitlab4j/api/models/CiYamlTemplatesApi.java Outdated
/**
* This class provides an entry point to all the GitLab CI YAML API calls.
*
* @see <a href="https://https://docs.gitlab.com/ee/api/templates/gitlab_ci_ymls.html">GitLab CI YAML API</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link is wrong

jmini added 3 commits September 8, 2023 17:47
@jmini
Rename
005e967
@jmini
Merge remote-tracking branch 'origin/main' into pr_1026
1fbadb4 
# Conflicts:
#	src/main/java/org/gitlab4j/api/GitLabApi.java
#	src/test/java/org/gitlab4j/api/TestGitLabApiBeans.java
@jmini
rename
3f22cb3
@jmini jmini merged commit 32d00b1 into gitlab4j:main Sep 8, 2023
jmini added a commit to jmini/gitlab-experiments that referenced this pull request Sep 13, 2023
@jmini
Add GitLabCiYamlScript
fcbbe32 
Test for gitlab4j/gitlab4j-api#1026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmini jmini jmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get .gitlab-ci.yml template
2 participants
@DoubleDPro @jmini