Skip to content

gitlab4j#1023 Add Field Iteration to Issue. #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2023
Merged

gitlab4j#1023 Add Field Iteration to Issue. #1027

merged 2 commits into from
Sep 19, 2023

Conversation

KoCoder
Copy link
Contributor

@KoCoder KoCoder commented Aug 31, 2023

  • Iteration Class
  • Getter and Setter for Iteration field

closes #1023

@KoCoder
gitlab4j#1023 Add Field Iteration to Issue.
0e54dbd 
+ Iteration Class
+ Getter and Setter for Iteration field
jmini
jmini requested changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me. Just a test case is missing.

jmini
jmini reviewed Sep 8, 2023
View reviewed changes
src/main/java/org/gitlab4j/api/models/Iteration.java Outdated
private Long groupId;
private String title;
private String descripion;
private IterationState state;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the json, the state is an integer:

https://gitlab.com/gitlab-org/gitlab/-/blob/4db027c5a18a8638bb0e6103b49010975058a9f8/doc/api/iterations.md#L56

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the code:
https://gitlab.com/gitlab-org/gitlab/-/blob/4db027c5a18a8638bb0e6103b49010975058a9f8/ee/app/models/iteration.rb#L14-18

It seems that there are only 3 possible values.

jmini
jmini reviewed Sep 8, 2023
View reviewed changes
src/main/java/org/gitlab4j/api/models/Iteration.java Outdated
private Long sequence;
private Long groupId;
private String title;
private String descripion;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo: Should be description

jmini added a commit to jmini/gitlab-experiments that referenced this pull request Sep 13, 2023
@jmini
Add IssueScript and IterationScript
8c60446 
Test for gitlab4j/gitlab4j-api#1027
@jmini
Copy link
Collaborator

jmini commented Sep 14, 2023

@KoCoder you did not grant Maintainers are allowed to edit this pull request on this PR.

I made the requested changes in jmini@f3cb01c

Can you add that to this PR (on the branch heek-feature-gitlab4j-1023-iterations)?

Or should I re-create an other PR to get this change integrated?

@KoCoder
Copy link
Contributor Author

KoCoder commented Sep 18, 2023

Hey, I've just cherry-picked your changes onto our feature branch.

@jmini jmini merged commit 55d3f92 into gitlab4j:main Sep 19, 2023
@PaulWoitaschek
Copy link

@jmini
Could you cut a release with this change included? Alternatively: Do snapshots get published of gitlab4j?

@PaulWoitaschek PaulWoitaschek mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmini jmini jmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add field iteration into Issue
3 participants
@KoCoder @jmini @PaulWoitaschek