Implemented being able to set a tag_list when creating and updating a project. #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmessner
reviewed
Apr 14, 2018
| @@ -646,10 +646,20 @@ public Project createProject(Project project, String importUrl) throws GitLabApi | |||
| if (isApiVersion(ApiVersion.V3)) { | |||
| boolean isPublic = (project.getPublic() != null ? project.getPublic() : project.getVisibility() == Visibility.PUBLIC); | |||
| formData.withParam("public", isPublic); | |||
|
|
|||
| if (project.getTagList() != null && !project.getTagList().isEmpty()) { | |||
There was a problem hiding this comment.
Would prefer to throw the following exception:
IllegalArgumentException("GitLab API v3 does not support tag lists when creating projects")
gmessner
reviewed
Apr 14, 2018
| @@ -877,10 +887,20 @@ public Project updateProject(Project project) throws GitLabApiException { | |||
| formData.withParam("visibility_level", project.getVisibilityLevel()); | |||
| boolean isPublic = (project.getPublic() != null ? project.getPublic() : project.getVisibility() == Visibility.PUBLIC); | |||
| formData.withParam("public", isPublic); | |||
|
|
|||
| if (project.getTagList() != null && !project.getTagList().isEmpty()) { | |||
There was a problem hiding this comment.
See above comment about throwing an exception.
|
@jimrinhealthcare |
gmessner
added a commit
that referenced
this pull request
Apr 15, 2018
gmessner
added a commit
that referenced
this pull request
Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've left a note in for the V3 API section as I wasn't sure if you'd prefer to just ignore tag lists here (Gitlab doesn't appear to do anything with them if you send them) or throw some sort of exception.
I've added what I think the unit test changes should be, but couldn't work out what needed setting up to run them.