Skip to content

Adds a new updateMergeRequest method with more attributes #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

armsnyder
Copy link
Contributor

@armsnyder armsnyder commented Jun 27, 2018

I deprecated the existing updateMergeRequest method and added a new updateMergeRequest method which accepts more parameters. These new parameters correspond to the attributes listed here that were previously not settable.

Closes #205

Since there were now 3 different updateMergeRequest methods which contained duplicated code, I abstracted the common logic to a protected method

protected MergeRequest updateMergeRequest(Integer projectId, Integer mergeRequestIid, Form formData)

The reason it is protected and not private is so that in the future, users of this library can extend the class to add new attributes themselves, instead of waiting for the library to update. I'm curious if making it a public method would be preferable.

@gmessner
Copy link
Collaborator

@armsnyder
Thanks for the contribution, looks good and I always appreciate unut tests being included.

@gmessner gmessner merged commit f1f270c into gitlab4j:master Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants